Skip to content

py-plaid: add package#4925

Open
williampiat3 wants to merge 9 commits into
spack:developfrom
williampiat3:Plaid
Open

py-plaid: add package#4925
williampiat3 wants to merge 9 commits into
spack:developfrom
williampiat3:Plaid

Conversation

@williampiat3
Copy link
Copy Markdown
Contributor

@williampiat3 williampiat3 commented May 21, 2026

This PR depends on PR #4888, waiting for it to be merged

@williampiat3
Copy link
Copy Markdown
Contributor Author

@spackbot fix style

@spackbot-app
Copy link
Copy Markdown

spackbot-app Bot commented May 21, 2026

Let me see if I can fix that for you!

@spackbot-app
Copy link
Copy Markdown

spackbot-app Bot commented May 21, 2026

I was able to run spack style --fix for you!

spack style --fix
repos/spack_repo/builtin/packages/py_plaid/package.py
�[1;34m==> �[0mrunning ruff format
1 file left unchanged
�[1;34m==> �[0mrunning ruff check
�[1m�[91mE501 �[0m�[1mLine too long (106 > 99)�[0m
  �[1m�[94m-->�[0m repos/spack_repo/builtin/packages/py_plaid/package.py:11:100
   �[1m�[94m|�[0m
�[1m�[94m10 |�[0m class PyPlaid(PythonPackage):
�[1m�[94m11 |�[0m     """A package that implements a data model tailored for AI and ML in the context of physics problems"""
   �[1m�[94m|�[0m                                                                                                    �[1m�[91m^^^^^^^�[0m
�[1m�[94m12 |�[0m
�[1m�[94m13 |�[0m     homepage = "https://github.com/PLAID-lib/plaid"
   �[1m�[94m|�[0m

Found 2 errors (1 fixed, 1 remaining).
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

@williampiat3 williampiat3 marked this pull request as ready for review May 21, 2026 14:57
Comment thread repos/spack_repo/builtin/packages/py_plaid/package.py Outdated

# Build deps
with default_args(type="build"):
depends_on("py-setuptools@60:76.1.0")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there an upper bounds restriction?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the current pyproject.toml is not compatible with setuptools >=77, I have a PR for the next plaid release to fix this

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread repos/spack_repo/builtin/packages/py_plaid/package.py Outdated
Comment thread repos/spack_repo/builtin/packages/py_plaid/package.py
Comment thread repos/spack_repo/builtin/packages/py_plaid/package.py Outdated
Comment thread repos/spack_repo/builtin/packages/py_plaid/package.py Outdated
@RikkiButler20 RikkiButler20 self-assigned this May 22, 2026
@RikkiButler20 RikkiButler20 changed the title New recipe: py-plaid py-plaid: add package May 22, 2026
@RikkiButler20
Copy link
Copy Markdown
Contributor

Were you able to successfully build py-plaid?

@williampiat3
Copy link
Copy Markdown
Contributor Author

Were you able to successfully build py-plaid?

Yes the recipe worked for me on linux, did not test on windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants